Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDING-53] Feed 생성 API 구현 #197
[DDING-53] Feed 생성 API 구현 #197
Changes from 16 commits
fa87eee
4083061
a1f30d8
26e903e
150d763
36f59eb
2fa135e
dd4dc19
23393da
bfbb261
63d48e7
f0e6450
af1b866
c8840b4
3992d0b
e1f58e1
b539e5b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
하나의 피드가 동시에 이미지와 비디오로 처리될 가능성에 대한 고려
feed.isImage()
와feed.isVideo()
가 모두true
가 될 수 있는 상황이라면,fileMetaDataService.updateStatusToCoupled()
가 두 번 호출될 소지가 있습니다.실업무 로직상 ‘이미지 또는 비디오 중 하나’만 가능하다면
else if
로 제어하여 중복 처리를 회피하는 방안을 고려해 주세요.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
단일 Feed 조회 시 존재하지 않는 자원에 대한 예외 처리
feedService.getById(feedId)
의 결과가 없을 때 예외 처리를 어떻게 할지 확인이 필요합니다. 응답 형태(404 Not Found
등)와 예외 메시지를 클라이언트에 일관성 있게 전달하도록 제안드립니다.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오탈자 수정이 필요합니다.
해당 예외 메시지에서 불필요한
)
문자가 포함되어 있습니다. 아래와 같이 수정하여 문자열을 올바르게 닫아야 합니다.📝 Committable suggestion