-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDING-64] presignedUrl - 이미지 순서 적용 구현 #196
Merged
Merged
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6ef4bc8
refactor: FileMetaData 필드(order) 추가
5uhwann 1017b4d
feat: FileMetaDataService - order 포함 update 구현
5uhwann 477d211
refactor: Notice - 이미지 순서 지정 로직 추가
5uhwann 2c53bc2
refactor: FixZone - 이미지 순서 지정 로직 추가
5uhwann daf91f8
refactor: 이미지, 파일 정보 객체 null 체킹 로직 추가
5uhwann 78e74fd
refactor: 필드명 오타 수정
5uhwann 870397f
refactor: 필드명 오타 수정
5uhwann d73e90e
refactor: 이미지, 파일 순서 요청 검증조건 추가
5uhwann d974121
build: 테스트 커버리지 측정 범위 조정
5uhwann a184896
build: sonar 누락 properties 추가
5uhwann 9453dff
refactor: inner record 클래스 접근제어자 수정
5uhwann 1870246
refactor: 변수명 오타 수정
5uhwann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
...in/java/ddingdong/ddingdongBE/domain/filemetadata/service/dto/FileMetaDataIdOrderDto.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
package ddingdong.ddingdongBE.domain.filemetadata.service.dto; | ||
|
||
public record FileMetaDataIdOrderDto( | ||
String fileMetaDatId, | ||
5uhwann marked this conversation as resolved.
Show resolved
Hide resolved
|
||
int fileMetaDataOrder | ||
|
||
) { | ||
|
||
public static FileMetaDataIdOrderDto of(String fileMetaDatId, int fileMetaDataOrder) { | ||
return new FileMetaDataIdOrderDto(fileMetaDatId, fileMetaDataOrder); | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,7 @@ | |
import ddingdong.ddingdongBE.domain.fixzone.service.dto.query.AdminFixZoneQuery; | ||
import ddingdong.ddingdongBE.domain.fixzone.service.dto.query.AdminFixZoneQuery.FixZoneCommentQuery; | ||
import ddingdong.ddingdongBE.file.service.dto.query.UploadedFileUrlQuery; | ||
import ddingdong.ddingdongBE.file.service.dto.query.UploadedFileUrlWithOrderQuery; | ||
import io.swagger.v3.oas.annotations.media.Schema; | ||
import java.time.LocalDateTime; | ||
import java.util.List; | ||
|
@@ -54,17 +55,19 @@ public static AdminFixZoneResponse from(AdminFixZoneQuery query) { | |
description = "어드민 - 픽스존 이미지 URL 조회 응답" | ||
) | ||
record FixZoneImageUrlResponse( | ||
@Schema(description = "이미지 순서", example = "1") | ||
int order, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. p3) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. update시 순서를 클라이언트에서 인식해서 지정해줘야해서 order를 응답에 포함시켰습니다! |
||
@Schema(description = "원본 url", example = "url") | ||
String originUrl, | ||
@Schema(description = "cdn url", example = "url") | ||
String cdnUrl | ||
) { | ||
|
||
public static FixZoneImageUrlResponse from(UploadedFileUrlQuery query) { | ||
public static FixZoneImageUrlResponse from(UploadedFileUrlWithOrderQuery query) { | ||
if (query == null) { | ||
return null; | ||
} | ||
return new FixZoneImageUrlResponse(query.originUrl(), query.cdnUrl()); | ||
return new FixZoneImageUrlResponse(query.order(), query.originUrl(), query.cdnUrl()); | ||
} | ||
|
||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default를 0으로 설정해서 null값을 가질 일이 없어지는 것일까요?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
맞습니다! order를 primitive type으로 해서 nullable하게 할 경우 조회 시 null값일 경우 에러가 발생해 해당 방식으로 지정했습니다.