Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing data in preview when editing #97

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zachlipton
Copy link
Collaborator

This is a draft PR that adds a failing test (which oddly enough, I had laying around uncommitted in my dev environment for some reason) showing a (potentially?) unwanted consequence from #95: if ?preview=true is passed, we now only return data from unpublished batches, but edit batches are sparse—they don't contain rows that aren't being edited.

What this means is that if you edit the data for one state and preview, the underlying published data is not returned when you call endpoints like /states/daily?preview=true, only the data in preview is returned

I'm not entirely sure what to do with this, but wanted to share the test as a starting point.

@zachlipton zachlipton requested a review from julia326 July 8, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant