Feature/gql exporter #433
Open
Feature/gql exporter #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdacoello
force-pushed
the
feature/gql-exporter
branch
from
8e6ef04 to
dcde474
Compare
| field_dict[additional_field[0]] = field(node, f" {str(additional_field[1])}: ") | ||
| def get_gql_unit_enums() -> Dict[str, graphene.Enum]: | ||
| """Get GraphQL enums for VSS units and quantity kinds.""" | ||
| global mapping_quantity_kinds_df |
There was a problem hiding this comment.
why does this need to be global and not just an argument / return value of the function?
There was a problem hiding this comment.
For simplicity, to avoid passing that to many places. This variable is only modified once but accessed elsewhere
src/vss_tools/exporters/graphql.py
Outdated
|
|
||
| def get_graphql_schema(tree: VSSNode) -> graphene.Schema: | ||
| """Create a GraphQL schema from the VSS tree.""" | ||
| global vss_metadata_df, vss_branches_df, vss_leaves_df, gql_unit_enums, gql_allowed_enums, gql_instance_enums |
There was a problem hiding this comment.
So many globals. Isn't it possible to pass them through where needed?
There was a problem hiding this comment.
It is possible, but as I have many functions, it will imply passing them over multiple times.
jdacoello
force-pushed
the
feature/gql-exporter
branch
11 times, most recently
from
5190be1 to
50cadb6
Compare
|
MoM:
|
| ): | ||
| """ | ||
| Export as GraphQL. | ||
| Export a VSS specification to a GraphQL schema. | ||
| """ | ||
| tree, _ = get_trees( |
There was a problem hiding this comment.
what about the type tree aka structs?
jdacoello
force-pushed
the
feature/gql-exporter
branch
from
50cadb6 to
a5728b5
Compare
jdacoello
force-pushed
the
feature/gql-exporter
branch
10 times, most recently
from
dc8acfa to
142797e
Compare
jdacoello
force-pushed
the
feature/gql-exporter
branch
9 times, most recently
from
ee4dcf1 to
9942f6c
Compare
|
MoM:
|
erikbosch
reviewed
Dec 9, 2024
Signed-off-by: Daniel Alvarez-Coello <[email protected]>
jdacoello
force-pushed
the
feature/gql-exporter
branch
from
9942f6c to
63095a8
Compare
|
There are other features or possible improvements to the GraphQL VSS counterpart. For example:
I am happy to hear more feedback from the community in case there is any suggestion or observation about the modeling decisions and proposed structures to make this even better. |
|
MoM:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue #431. It refactors entirely the GraphphQL exporter to offer a usable schema structure. For extended explanation, please see the updated documentation of the exporter
docs/graphql.md.