Remove Unnecessary Plugin Pane Controls #632
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removal of unnecessary plugin pane controls. Signed-off by : Pavithra Anand <[email protected]>
|
could you please provide a screenshots for comparison? |
vifactor
reviewed
Feb 28, 2025
src/mainwindow.cpp
Outdated
| @@ -3404,7 +3404,7 @@ void MainWindow::on_pluginWidget_customContextMenuRequested(QPoint pos) | |||
| menu.addAction(action); | |||
| } | |||
|
|
|||
| menu.addSeparator(); | |||
| /*menu.addSeparator(); | |||
There was a problem hiding this comment.
if code is not needed anymore, please remove it instead of commenting out
There was a problem hiding this comment.
Ok. I removed it.
|
Here is the screenshot of before/after removal of plugin pane controls. |
Removed the plugin pane controls and Move Up/ Move Down from context menu Signed-off by : Pavithra Anand <[email protected]>
vifactor
approved these changes
Mar 3, 2025
There was a problem hiding this comment.
Codewise ok for me, however I do not know why you think those controls were useless. @alexmucde to decide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removal of unnecessary plugin pane controls.
Signed-off by : Pavithra Anand [email protected]