Skip to content

Removed the usage of size_t in libopen1722 and removed includes of st…#88

Merged
SebastianSchildt merged 1 commit intoCOVESA:mainfrom
boschglobal:fix/include_stdint
Mar 14, 2025
Merged

Removed the usage of size_t in libopen1722 and removed includes of st…#88
SebastianSchildt merged 1 commit intoCOVESA:mainfrom
boschglobal:fix/include_stdint

Conversation

@nayakned
Copy link
Copy Markdown
Collaborator

…dint.h

@SebastianSchildt
Copy link
Copy Markdown
Collaborator

I think there may be a more robust fix.

  • probably should also include stddef.h (size_t is nor guaranteed to be in stdint)
  • the "extern C" should be moved on top in the Define.h, just to make sure C standard lib definitions did not get hidden in std:: namespace

Untested :D

Generally, I think making sure the central Define.h being used in all ACF's is a good change.

Signed-off-by: Naresh Nayak <Naresh.Nayak@de.bosch.com>
@nayakned nayakned force-pushed the fix/include_stdint branch from f2a186c to c8df92e Compare March 14, 2025 14:54
@nayakned nayakned marked this pull request as ready for review March 14, 2025 14:54
Copy link
Copy Markdown
Collaborator

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🎲

@SebastianSchildt SebastianSchildt merged commit 753586b into COVESA:main Mar 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants