Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated and filled the footer to width #117

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ameynaik-9
Copy link
Member

Description

Ans- The footer was just in centre and was not sized perfectly so I have made it fixed to width

Fixes

Fixes #[issue number] by @[issue author]

Types of changes

  • Bug/Hot fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring Old Code ( non-breaking change replacing already existing code )
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING guidelines in repository.
  • My pull request has a descriptive title and is attached to an existing issue.
  • I haven't repeated the code and it follows established code style of repository.
  • My branch is up-to-date with upstream branch.
  • All new and existing tests passed.

@netlify
Copy link

netlify bot commented Oct 6, 2022

Deploy Preview for cops ready!

Name Link
🔨 Latest commit f703fcf
🔍 Latest deploy log https://app.netlify.com/sites/cops/deploys/633f50d3e993f2000922cb6a
😎 Deploy Preview https://deploy-preview-117--cops.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@IamEzio IamEzio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ameynaik-9. However, I have some concerns:

  • The navbar is broken in mobile view. Align it properly and try to make the ordering of the content similar to the current one. Ref:
    Screenshot from 2022-10-07 17-58-49
  • On hover, don't change the text color to red, instead scale them as they are done in the navbar to maintain consistency.
  • Make sure the footer stays at the bottom of the page even if the rest of the content doesn't span to full page height. Refer to the team page of the deply preview:
    Screenshot from 2022-10-07 18-00-19

@king-11
Copy link
Member

king-11 commented Dec 12, 2022

@ameynaik-9 updates on this?

@ameynaik-9
Copy link
Member Author

ameynaik-9 commented Dec 12, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants