Adds function for getting enabled languages#136
Merged
ryanmrichard merged 2 commits intomasterfrom Jun 18, 2025
Merged
Conversation
1 task
zachcran
reviewed
Jun 17, 2025
Contributor
zachcran
left a comment
zachcran
left a comment
There was a problem hiding this comment.
I left some recommendations, but overall it LGTM.
|
🚀 [bumpr] Bumped! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this pull request associated with an issue(s)?
Not in this repo.
Description
This PR adds a function
cpp_enabled_languagesthat will query CMake to figure out what languages have been enabled. At present, one of the tests is commented out. This test won't work until CMakeTest is updated to use this functionality (PR forthcoming). Once CMakeTest is updated, I'll launch a new PR to uncomment the test.TODOs
None