-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WNMGDS-3243] Upgraded Gatsby to v5 #3477
Changes from 15 commits
4875374
67b05f5
de3a7eb
80c41a3
330f082
b8c1fb2
44f3dcd
2fe241a
4497939
579062c
3925769
7027b83
229d2ed
c639fed
0814bcd
de66bb7
adabb3f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,8 +12,9 @@ import { Alert } from '@cmsgov/design-system'; | |
<ThemeContent neverThemes={['medicare']}> | ||
<Alert variation="error"> | ||
<p class="ds-c-alert__text"> | ||
This component is only used for Medicare. Please use the theme switcher to view the component | ||
with Medicare styles. | ||
{ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok, so the brackets prevent a second There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, that's correct |
||
'This component is only used for Medicare. Please use the theme switcher to view the component with Medicare styles.' | ||
} | ||
</p> | ||
</Alert> | ||
</ThemeContent> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -180,19 +180,19 @@ Align columns horizontally or vertically using [flexbox utility classes](/utilit | |
</div> | ||
<div | ||
class="ds-l-row ds-u-align-items--start ds-u-border--1 ds-u-padding--1 ds-u-margin-y--2" | ||
style="height: 100px" | ||
style={{ height: 100 }} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The lack of units here makes me nervous. PX is the default? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, PX is the default |
||
> | ||
<div class="ds-l-col--3">Top</div> | ||
</div> | ||
<div | ||
class="ds-l-row ds-u-align-items--center ds-u-border--1 ds-u-padding--1 ds-u-margin-y--2" | ||
style="height: 100px" | ||
style={{ height: 100 }} | ||
> | ||
<div class="ds-l-col--3">Center</div> | ||
</div> | ||
<div | ||
class="ds-l-row ds-u-align-items--end ds-u-border--1 ds-u-padding--1 ds-u-margin-y--2" | ||
style="height: 100px" | ||
style={{ height: 100 }} | ||
> | ||
<div class="ds-l-col--3">Bottom</div> | ||
</div> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,10 +4,29 @@ order: 70 | |
intro: System color tokens are the entire set of color tokens from which our themes are built. | ||
--- | ||
|
||
import ColorContrastGuidelines from '../../src/reusable-text-snippets/ColorContrastGuidelines.mdx'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wasn't able to recreate this functionality in Gatsby v5, so instead of using the reusable text snippet, I've gone ahead and copied and pasted the contents into this markdown file, plus the other three locations where the content was changed. Another option would be to create a react component and import it accordingly. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the React component approach makes the most sense. Do you agree? If so, we can spin up a ticket for that work. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jack-ryan-nava-pbc agreed! New ticket -> https://jira.cms.gov/browse/WNMGDS-3287 |
||
|
||
While this page shows the full range of colors, it's essential to use the theme color tokens identified for your brand's experience when building your product. Think of system color tokens like an entire box of crayons; our themes use specific colors from the box, not all of them. | ||
|
||
<ColorRamps /> | ||
|
||
<ColorContrastGuidelines /> | ||
## Accessibility considerations | ||
|
||
### Text contrast | ||
|
||
WCAG 2.0+ AA requires a contrast ratio of a minimum of 4.5:1 for normal, or body, text. Large text is easier to read, so the contrast requirement is reduced to 3:1. WCAG defines large text as text that is 24px and larger or 18.5px and larger if it is bold. | ||
|
||
Text over gradients and background images still need to meet contrast requirements. | ||
|
||
### Non-text contrast | ||
|
||
Elements that are not text, but still important, including buttons, icons that convey information, data visualizations (charts and graphs), and form inputs need a contrast ratio of at least 3:1. Also included in this are states of elements such as the selected state of an element, expanded vs. collapsed, active vs. inactive, elements with keyboard focus, etc. | ||
|
||
### Easily test your color combinations | ||
|
||
Note that the colors listed only display colors that are available but when you are pairing colors together, make sure the color contrast ratio is sufficient. Here are three tools we suggest for testing color contrast: | ||
|
||
[WebAIM Color Contrast Checker](https://webaim.org/resources/contrastchecker/) | ||
|
||
[Deque Color Contrast Analyzer](https://dequeuniversity.com/color-contrast) | ||
|
||
[Color Contrast Analyzer by TPGi](https://www.tpgi.com/color-contrast-checker/) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The next set of markdown file changes have to do with preventing Interleaving