Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WNMGDS-3191] Note Content Component #3419

Merged
merged 44 commits into from
Mar 24, 2025
Merged
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
abffb46
Initial styling and component setup
jack-ryan-nava-pbc Jan 29, 2025
1ee0b46
Adding support for quotations
jack-ryan-nava-pbc Jan 29, 2025
d7694e9
Refining styling
jack-ryan-nava-pbc Jan 30, 2025
f4264e2
[WNMGDS-3183] Validate compatibility with different React versions th…
pwolfert Jan 29, 2025
d43477b
[WNMGDS-3166] Add eMedicare footer web-component (#3405)
tamara-corbalt Jan 31, 2025
b29fbf3
Author and citation logic implemented
jack-ryan-nava-pbc Jan 31, 2025
778c011
Beginnging tests
jack-ryan-nava-pbc Jan 31, 2025
0fe52af
Merge branch 'main' into jryan/WNMGDS-3191-box-content
jack-ryan-nava-pbc Jan 31, 2025
a26c38a
Updated tests, use icon and update display logic a bit
jack-ryan-nava-pbc Feb 3, 2025
0dfcf0f
Export the BoxContent component
jack-ryan-nava-pbc Feb 3, 2025
9a7d854
New VRTs
jack-ryan-nava-pbc Feb 3, 2025
92cd24e
Update props table
jack-ryan-nava-pbc Feb 3, 2025
6d8f332
Update tests clean up logic in BoxQuotation
jack-ryan-nava-pbc Feb 4, 2025
2576e3d
Simple clean up
jack-ryan-nava-pbc Feb 4, 2025
a448676
Make BoxContent more generic
jack-ryan-nava-pbc Feb 4, 2025
4b3c544
Update specs
jack-ryan-nava-pbc Feb 4, 2025
dfb1485
Merge branch 'main' into jryan/WNMGDS-3191-box-content
jack-ryan-nava-pbc Feb 4, 2025
70b27b7
snapshots after refactor
jack-ryan-nava-pbc Feb 4, 2025
93355f1
Support forced colors mode and simplify some vars
jack-ryan-nava-pbc Feb 5, 2025
f00e06a
Allow for additional classes to be added to the box quotation element.
jack-ryan-nava-pbc Feb 5, 2025
d244b22
dont wrap icon in h2 and update specs
jack-ryan-nava-pbc Feb 5, 2025
ced1952
Update snapshots again
jack-ryan-nava-pbc Feb 5, 2025
485d679
Merge branch 'main' into jryan/WNMGDS-3191-box-content
jack-ryan-nava-pbc Feb 6, 2025
20b2062
Update citation styling
jack-ryan-nava-pbc Feb 6, 2025
3597da8
Attempt at nested stories
jack-ryan-nava-pbc Feb 7, 2025
9413587
Separated boxquotation into a separate story
jack-ryan-nava-pbc Feb 7, 2025
2e61ba9
Add underlying html to storybook props update tests and snapshots and…
jack-ryan-nava-pbc Feb 10, 2025
8311618
Merge branch 'main' into jryan/WNMGDS-3191-box-content
jack-ryan-nava-pbc Feb 10, 2025
46befda
Update snapshots
jack-ryan-nava-pbc Feb 11, 2025
758b22a
lessen severity of missing props make a function into a component and…
jack-ryan-nava-pbc Feb 12, 2025
101ec5d
Update failing unit snapshot
jack-ryan-nava-pbc Feb 12, 2025
3aab46b
Merge branch 'main' into jryan/WNMGDS-3191-box-content
jack-ryan-nava-pbc Feb 13, 2025
96a974f
Merge branch 'main' into jryan/WNMGDS-3191-box-content
jack-ryan-nava-pbc Feb 18, 2025
745da8e
Merge branch 'main' into jryan/WNMGDS-3191-box-content
jack-ryan-nava-pbc Feb 19, 2025
3850dd0
Merge branch 'main' into jryan/WNMGDS-3191-box-content
jack-ryan-nava-pbc Feb 27, 2025
250c150
Merge branch 'main' into jryan/WNMGDS-3191-box-content
jack-ryan-nava-pbc Mar 5, 2025
741036e
Merge branch 'main' into jryan/WNMGDS-3191-box-content
jack-ryan-nava-pbc Mar 13, 2025
93cf3dc
The great renaming
jack-ryan-nava-pbc Mar 13, 2025
be5b4a2
Merge branch 'main' into jryan/WNMGDS-3191-box-content
jack-ryan-nava-pbc Mar 18, 2025
c70abef
Rename story
jack-ryan-nava-pbc Mar 19, 2025
74b5466
Merge branch 'main' into jryan/WNMGDS-3191-box-content
jack-ryan-nava-pbc Mar 24, 2025
663f531
Updated test snapshots
jack-ryan-nava-pbc Mar 24, 2025
fdfe1f8
Merge branch 'main' into jryan/WNMGDS-3191-box-content
jack-ryan-nava-pbc Mar 24, 2025
eec298a
Merge branch 'main' into jryan/WNMGDS-3191-box-content
jack-ryan-nava-pbc Mar 24, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refining styling
  • Loading branch information
jack-ryan-nava-pbc committed Jan 30, 2025

Verified

This commit was signed with the committer’s verified signature.
commit d7694e96dabeb17b428db2cef7902a137bcbc9ba
18 changes: 15 additions & 3 deletions packages/design-system/src/components/BoxContent/BoxQuotation.tsx
Original file line number Diff line number Diff line change
@@ -19,9 +19,21 @@ export interface BoxQuotationsProps {
export const BoxQuotation: FunctionComponent<BoxQuotationsProps> = (props: BoxQuotationsProps) => {
const { author, children, citation } = props;
return (
<figure>
<blockquote cite={citation}>{children}</blockquote>
{author && <figcaption>&mdash; {author}</figcaption>}
<figure className="ds-c-box-content-quotation">
<blockquote className="ds-c-box-content-quotation--blockquote" cite={!author ? citation : ''}>
{children}
</blockquote>
{author && (
<figcaption className="ds-c-box-content-quotation--caption">
&mdash; {author}{' '}
{citation && (
<cite>
{'/ '}
{citation}
</cite>
)}
</figcaption>
)}
</figure>
);
};
17 changes: 11 additions & 6 deletions packages/design-system/src/styles/components/_BoxContent.scss
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
@use '../layout' as *;

.ds-c-box-content {
padding: var(--spacer-4);
background-color: var(--color-info-lightest);
padding: var(--spacer-2);
background-color: var(--color-gray-lightest);
color: var(--color-base);
border-radius: var(--radius-default);
border: 1px solid var(--color-transparent);
@@ -17,7 +17,7 @@
}

.ds-c-box-content--bordered {
border: 1px solid var(--color-gray-lighter);
border: 1px solid var(--color-border-dark);
background-color: var(--color-background);

@media (forced-colors: active) {
@@ -31,9 +31,14 @@
}

.ds-c-box-content__text {
margin-block-start: var(--spacer-2);
margin-block-start: var(--spacer-half);
}

.ds-c-box-content--quotation {
padding-inline-start: $spacer-2;
.ds-c-box-content-quotation--blockquote {
margin: 0;
}

.ds-c-box-content-quotation--caption {
margin-block-start: var(--spacer-half);
font-weight: var(--font-weight-semibold);
}