Add bottom margin to button in report-mardown-editor#258
Add bottom margin to button in report-mardown-editor#258pierreconti wants to merge 2 commits intomasterfrom
Conversation
|
|
||
| button { | ||
| margin: 0.5em 0 0 0.5em; | ||
| margin: 1em 0 1em 1em; |
There was a problem hiding this comment.
Hey @pierreconti,
I find the margin-bottom confusing: it does not collapse with the .add-block-prompt .actions margin-top below it. Is this intentional?
On hover, the top buttons are flush with the top of the left-hand blue bar; but the bottom buttons aren't flush with the bottom, because of this new margin-bottom. Is that intentional?
Your answers will decide how we rewrite this code. margin is "quick-and-confusing"; padding is legible but cumbersome. Now that I'm confused, it's time to switch to using padding :).
There was a problem hiding this comment.
Ok I switched to padding while keeping the distance consistent above and below .buttons
There was a problem hiding this comment.
@pierreconti Please answer my question:
On hover, the top buttons are flush with the top of the left-hand blue bar; but the bottom buttons aren't flush with the bottom, because of this new
margin-bottom. Is that intentional?
2 participants
It was not padding ;) Also added a little more margin around