Add support for levels in the ConditionalDebug class. #438
+205
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmn30
reviewed
Jan 31, 2025
sdk/include/debug.hh
Outdated
| @@ -592,26 +666,31 @@ namespace | |||
| * using Debug = ConditionalDebug<DebugFoo, "Foo">; | |||
There was a problem hiding this comment.
Does this comment need updating?
rmn30
approved these changes
Jan 31, 2025
rmn30
reviewed
Jan 31, 2025
| @@ -676,6 +755,7 @@ namespace | |||
| } | |||
| } | |||
| }; | |||
|
|
|||
| /** | |||
| * Function-like class for assertions that is expected to be used via | |||
| * the deduction guide as: | |||
There was a problem hiding this comment.
Would it be useful to give Assertions a DebugLevel, like log messages?
|
Would be nice if one or more of the examples was updated to show how this can be uses. |
davidchisnall
force-pushed
the
debug-level
branch
6 times, most recently
from
45e3c3e to
e51d9aa
Compare
The class is now instantiated with a threshold level, from None to Error (for backwards compatibility, true means Information and false means None). Log messages also provide a log level (Information if none is provided) and will fire if the log level is greater than or equal to the threshold. The build system now has a `debugLevelOption` that allows specifying fine-grained levels. The existing `debugOption` works as before. The allocator is now extended to use `debugLevelOption`.
davidchisnall
force-pushed
the
debug-level
branch
from
e51d9aa to
cc7cbfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class is now instantiated with a threshold level, from None to Error (for backwards compatibility, true means Information and false means None).
Log messages also provide a log level (Information if none is provided) and will fire if the log level is greater than or equal to the threshold.