Add trylock to ticket locks. #388
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not impossible to do, it's just annoying, I realised while writing the book paragraph explaining that it's impossible.
davidchisnall
force-pushed
the
trylock-ticket
branch
from
72dc699 to
991938d
Compare
|
Updating with offline discussion: this code is currently wrong because the unlock path does not do a futex wake if there are no outstanding waiters. Not sure if it’s worth fixing, we currently have no users of flag locks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not impossible to do, it's just annoying, I realised while writing the book paragraph explaining that it's impossible.