-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style Improvements #9
Conversation
changed font size to match other modules; changed language and units option to be taken from default; added configuration option to display walking steps; added configuration option to display the departure station; added display of arrival time in default time format; added sorting of alternative routes by arrival time; added exclusion of alternatives based on walking time; added fading with parameters identical to the default calendar module; changed update to update time every 15sec, but only pull new routes from google every x minutes as specified by config
made symbols smaller to match smaller font size
added english dictionary
replaced “this.data;” with “this.response;” in all its (3) occurrences in localtransport.js, following POIMann in issue CFenner#5 from 6th Jun, 2016
quick fix of bug, so that departure stations can be displayed
Hey, how do I install it with these new improvements? I tried replacing the code with this code and the magic mirror did not display at all - just a black screen. Thanks :) |
Can you pull the latest code from my site? I remember there was some minor bug in this merge request, but it should only really cause issues with a specific setting (which is being ignored because of the bug). Long story short I fixed it but forgot to set up another merge request... Could be the bug was more serious than I thought? |
Seems like GitHub is linking to the latest version of my fork already. Can you check that you set all the parameters required and that the error is not from another change you made? Can you send me the options you have set (you can leave the API key blank or as XXX - I will replace it with my own to test...) |
different previews to show various options
added maxModuleWidth, displayArrival, displayWalkType, made sure all times are displayed in according language
Currently updating some things to make sure I didn't accidentally leave the repository in an old state. Therefore the latest version now probably doesn't work, as some translation strings are missing. Will upload the rest as soon as I have time again. (remind me if I stay silent for too long ;-) ) |
ok, that should be all :-D |
Maybe I add the code wrong. I simply replaced the code you wrote on this page with the original, is that correct? Is there an easier way to install it through the terminal? I'm sorry, I'm quite new to this. |
If you replaced ALL the original files with mine AND added the files I added AND updated your config file, then you should be fine :-D |
Is this in a state I can simply merge it? |
@CFenner yes, should be :-) |
Several style improvements making the font size equal to other modules and allowing for different style options to be set, some shown below:



This fixes issue #5, #6 and #8
Explanation of config variables: