feat: hint banners in /status page #307 #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's how warnings look like if every warning is present. Notice how both ursa_url warning and datasets compacting warning are dismissable, but no agents warning is not. |
msm-cert
requested changes
Oct 11, 2024
Comment on lines
+41
to
+43
| ${duplicateURLS.join( | ||
| ", " | ||
| )}. Something might be wrong with backend configuration.`; |
There was a problem hiding this comment.
another nitpick, but maybe extract duplicateURLS.join to a separate variable (to avoid long expression inside)
There was a problem hiding this comment.
I guess i'm merging it like it is.
msm-cert
approved these changes
Oct 17, 2024
Comment on lines
+41
to
+43
| ${duplicateURLS.join( | ||
| ", " | ||
| )}. Something might be wrong with backend configuration.`; |
There was a problem hiding this comment.
I guess i'm merging it like it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
What is the current behaviour?
Currently user might not be aware of possible unwanted backend settings.
What is the new behaviour?
Now user receives warnings on
/statuspage which warn them about missing agents, multiple agents connected with the same ursa_url or if it is advised to compact their datasets.Test plan
Either backend setup should be messed up with or stub data filled into backend responses. Unfortunately I'm not currently aware of better methods without further messing with frontend code.
Closing issues
fixes #307