Skip to content

Conversation

@briri
Copy link
Collaborator

@briri briri commented Jan 23, 2026

Description

Part of #1099

The licenses GraphQL query changed. This updates the licenseSearch question type to match the updated GraphQL query.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

All tests are passing. The front end isn't actually using the query defined in the type, it has the generated graphQL from the backend instead. See #1129 for the changes to the frontend

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I updated the CHANGELOG.md and added documentation if necessary
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

- Updated `src/questions/__tests__/optionBasedQuestions.spec.ts` to use `selected` in place of `checked` for checkboxes

# v3.0.0
# v2.3.0
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a prior PR I had originally set this to 3.0.0 but then changed my mind and set it to 2.3 in the PR, but forgot to change this in the CHANGELOG.

This just sets it back to what it should have been.

# v3.1.0
- Updated LicenseSearch to use updated `licenses` graphQL query

# v3.0.0
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package.json was a 3.0.0 not 4.0.0, so just updating to reflect the accurate version number

{
"name": "@dmptool/types",
"version": "3.0.0",
"version": "3.1.0",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the frontend and backend aren't using the graphQL query defined in the type, I am setting this as a minor version update. In the future, when we have external integrations, this would be a major upgrade since those systems may use the graphQL from the type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants