-
Notifications
You must be signed in to change notification settings - Fork 15
Add IMU diagnostics (related to #20) #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Added "/" for closing tags in package.xml * Moved lines to non-static function as required.
- Remove all diagnostics logic from phidget_api - Add diagnostics to phidgets_imu - Connect/disconnect/error states are propogated from callbacks - Periodic updates for diagnostics through processImuData() - Add Frequency and Timestamp (drift) diagnostics for imu/data_raw topic
Thanks for your PR! Unfortunately, I'm on vacation at the moment. I'll look into this in 3 weeks. |
Sorry for letting you wait for so long. I've thoroughly reviewed and tested this PR, and it looks good to me. Thanks for your work! @muhrix : please merge. |
@mintar Thanks for reviewing this. I am glad this PR was helpful. |
@muhrix Hello? |
@muhrix Ping... |
@mintar sorry, merging now! |
@mani-monaj I will try and get those releases sorted soon! :-) |
That would be great, I'm still waiting for that too. You remember the checklist in this comment, right? |
@mintar I do remember indeed! I had a look at it earlier today... Before doing anything else, I think we must revisit the idea of creating @idryanov never responded, so I can only assume we can move this into |
Thanks. That would be great. |
This is a continuation of #20. In summary, this:
phidget_api
tophidgets_imu
processImuData()
imu/data_raw
topicI did (1) because I think
phidgets_api
should better remain ROS agnostic. This was also suggested by @mintar.