Add unit tests and new functional tests #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a new suite of functional tests. The tests are moved into the `tests/functional` directory, which will allow us in subsequent commits to place unit tests in `tests/unit`.
This adds a suite of unit tests for the flask application and modifies the CI workflow to run unit tests in addition to the pre-commit checks.
Several tests are marked with @pytest.mark.xfail() to indicate places where the existing API may be problematic. For each of these tests, we need to determine if the existing behavior is correct, and if it is, modify the test so that it tests the current behavior and passes.
Add a GitHub workflow to run unit tests for each push and pull-request.
- Add pytest-coverage to test-requirements.txt, which allows us to
produce coverage reports.
- Update the CI workflow to include coverage reporting, which looks
like this:
Name Stmts Miss Cover
-----------------------------------------------
acct_mgt/__init__.py 0 0 100%
acct_mgt/app.py 141 10 93%
acct_mgt/defaults.py 2 0 100%
acct_mgt/kubeclient.py 33 19 42%
acct_mgt/moc_openshift.py 299 133 56%
acct_mgt/wsgi.py 7 7 0%
-----------------------------------------------
TOTAL 482 169 65%
- Add a note to the README about running unit tests.
x-branch: feature/tests
larsks
added a commit
that referenced
this pull request
Jan 18, 2022
Add unit tests and new functional tests * Introduce new functional tests * Add unit tests for flask app * Add unit tests for moc_openshift quota functions * Add unit tests for moc_openshift user functions * Add unit tests for identity operations * Add tests for acct_mgt.kubeclient * Add unit test workflow * Add support for coverage reporting
larsks
added a commit
that referenced
this pull request
Jan 18, 2022
* Introduce new functional tests * Add unit tests for flask app * Add unit tests for moc_openshift quota functions * Add unit tests for moc_openshift user functions * Add unit tests for identity operations * Add tests for acct_mgt.kubeclient * Add unit test workflow * Add support for coverage reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third in a series of pull requests (of which #62 is the first and #63 is the second).
This PR is all about tests: