Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Proof of Concept #26

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Initial Proof of Concept #26

wants to merge 2 commits into from

Conversation

ajamias
Copy link
Collaborator

@ajamias ajamias commented Oct 8, 2024

No description provided.

@ajamias ajamias linked an issue Oct 8, 2024 that may be closed by this pull request
Copy link
Collaborator

@tzumainn tzumainn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! Initial question - with only a single websocket port, won't requests from multiple users collide?

@ajamias
Copy link
Collaborator Author

ajamias commented Oct 8, 2024

I tested visiting the dashboard from two browsers on the same computer and they were both sending and receiving data on the same websocket port. Some more things I have to do is to are making sure each thread has its own memory scope, make the polling interval configurable, make the client able to connect to the websocket the host is on instead of juts localhost

@tzumainn
Copy link
Collaborator

tzumainn commented Oct 9, 2024

I tested visiting the dashboard from two browsers on the same computer and they were both sending and receiving data on the same websocket port. Some more things I have to do is to are making sure each thread has its own memory scope, make the polling interval configurable, make the client able to connect to the websocket the host is on instead of juts localhost

Were the two browsers two separate users?

@ajamias
Copy link
Collaborator Author

ajamias commented Oct 9, 2024

The two browsers were using the same account (uitest). But I am working right now on making each thread have its own thread local storage so that the users will only receive the data that they are meant to receive

@ajamias
Copy link
Collaborator Author

ajamias commented Nov 5, 2024

I added SSL to the websocket connection because trying to do this from chrome instead of firefox didn't work without SSL. But I tested this on two different computers and it looks like it works. I didn't test using with two different users because I get a strange 401 error if I try to log into my [email protected] account using openid connect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use websockets to speed up ESI UI
2 participants