Skip to content

Commit

Permalink
fix: need dockerfile basename for copying within docker build process (
Browse files Browse the repository at this point in the history
…#59)

* fix: need dockerfile basename for copying within docker build process

because the context is now inside the parent dir of the dockerfile

* chore: update CHANGELOG.md
  • Loading branch information
kelly-sovacool authored Jan 24, 2025
1 parent b85302b commit 46f6cce
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## actions development version

- fix `post-release` to make sure the sliding branch is created from the latest release tag. (#53, @kelly-sovacool)
- fix `build-docker` to set `$DOCKERFILE_BASENAME` for copying the Dockerfile inside the container. (#59, @kelly-sovacool)
- improvements to documentation website:
- add contributors page. (#54, @kelly-sovacool)
- list example workflows and improve navigation. (#55, @kelly-sovacool)
Expand Down
3 changes: 2 additions & 1 deletion build-docker/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ runs:
id: check_and_create_readme
run: |
echo "DOCKERFILE: $DOCKERFILE"
echo "DOCKERFILE_BASENAME: $DOCKERFILE_BASENAME"
echo "IMAGENAME: $IMAGENAME"
echo "BASEIMAGENAME: $BASEIMAGENAME"
echo "BUILD_DATE: $BUILD_DATE"
Expand All @@ -128,7 +129,7 @@ runs:
push: ${{ inputs.push }}
tags: ${{ env.IMAGENAME }}
build-args: |
DOCKERFILE=${{ env.DOCKERFILE }}
DOCKERFILE=${{ env.DOCKERFILE_BASENAME }}
BUILD_DATE=${{ env.BUILD_DATE }}
BUILD_TAG=${{ env.BUILD_TAG }}
REPONAME=${{ env.REPONAME }}
Expand Down
1 change: 1 addition & 0 deletions scripts/prepare_docker_build_variables.sh
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ artifact_name=$(echo $mdfile | sed 's|/|_|g')

# Output each variable to $GITHUB_ENV to pass it to the next steps
echo "DOCKERFILE=$dockerfile" >> $GITHUB_ENV
echo "DOCKERFILE_BASENAME=$bn_dockerfile" >> $GITHUB_ENV
echo "CONTEXT=$(dirname $dockerfile)" >> $GITHUB_ENV
echo "IMAGENAME=$imagename" >> $GITHUB_ENV
echo "BASEIMAGENAME=$baseimagename" >> $GITHUB_ENV
Expand Down

0 comments on commit 46f6cce

Please sign in to comment.