Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adapt send_email.py from spook #26

Merged
merged 6 commits into from
Dec 19, 2024
Merged

feat: adapt send_email.py from spook #26

merged 6 commits into from
Dec 19, 2024

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented Dec 19, 2024

Changes

Originally written for sending reports, but now making it more general so we can eventually use it to send slurm job status updates from biowulf.

Issues

see also https://github.com/CCBR/spook/pull/42

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • Write unit tests for any new features, bug fixes, or other code changes.
  • Update docs if there are any API changes.
  • Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/

originally written for sending reports
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.

Project coverage is 33.92%. Comparing base (8792f5a) to head (e55eb8e).

Files with missing lines Patch % Lines
src/ccbr_tools/send_email.py 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   32.41%   33.92%   +1.51%     
==========================================
  Files          17       18       +1     
  Lines        1265     1294      +29     
==========================================
+ Hits          410      439      +29     
  Misses        855      855              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelly-sovacool kelly-sovacool marked this pull request as ready for review December 19, 2024 18:02
@kelly-sovacool kelly-sovacool merged commit 52f5834 into main Dec 19, 2024
@kelly-sovacool kelly-sovacool deleted the sendmail branch December 19, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant