Conversation
This was referenced Jun 19, 2026
xroblot
reviewed
Jun 19, 2026
xroblot
reviewed
Jun 19, 2026
xroblot
reviewed
Jun 19, 2026
Adds `CebotarevDensity/ForMathlib/IndexImageCount.lean` with `setFinite_index_image_of_isBounded`: the `index n`-image of a bounded set is finite. Stated with `[Finite ι]` (Fintype recovered in the proof). The diameter/chart/frontier counts and their helpers follow in the stacked PRs 2/4-4/4. Wired into the umbrella import. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
xroblot
reviewed
Jun 22, 2026
Remove the section-level [Fintype ι] (and its omit) now that the sole remaining lemma uses [Finite ι]. Golf: have over haveI, dot-notation .subset, and fold the cast-nonneg fact into nlinarith. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
CBirkbeck
added a commit
that referenced
this pull request
Jul 9, 2026
…o [Finite ι] Per @xroblot's review (PR #13): put each private helper next to its first use, and weaken `setFinite`'s hypothesis. - `setFinite_index_image_of_isBounded` now takes `[Finite ι]`, recovering `Fintype` via `Fintype.ofFinite` inside the proof — dropping the `set_option linter.unusedFintypeInType false` workaround (the conclusion never mentions `Fintype.card`). - `ceil_natCast_mul_le_ceil_natCast_mul_add` moved next to its only consumer `ncard_index_image_le_of_diam_le`; `abs_sub_le_one_div_of_ceil_natCast_mul_eq` next to `ncard_index_image_chart_le`. This re-slices the stack so each helper lands in the PR that first uses it (#14, #15) instead of #13. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
CebotarevDensity/ForMathlib/IndexImageCount.leanwithsetFinite_index_image_of_isBounded— theindex n-image of a bounded set is finite. Stated with[Finite ι](theFintypeinstance is recovered viaFintype.ofFiniteinside the proof, since the conclusion never mentionsFintype.card). Wired into the umbrellaCebotarevDensityimport.Per @xroblot's review, the private ceiling/closeness helpers now live in the slices that first use them —
ceil_…in #14,abs_sub_…in #15 — rather than here.Builds green on the
v4.31.0-rc1/ mathlib-master pin.🤖 Generated with Claude Code