Node security updates#34
Open
erm156 wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Node dependencies to address Trivy-detected vulnerabilities and migrates CloudFront URL signing away from the deprecated aws-sdk v2 package.
Changes:
- Remove
aws-sdkv2 usage and switch CloudFront URL signing to@aws-sdk/cloudfront-signer. - Upgrade
express-mysql-sessionto v3 andmorganto v1.10. - Adjust CloudFront URL expiration handling to the new signer API (
dateLessThan).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Replaces/updates dependencies to address security findings (adds CloudFront signer; upgrades session store + logging). |
| connectors/cloudFrontConnector.js | Migrates CloudFront signed URL generation from AWS SDK v2 signer to AWS SDK v3 CloudFront signer. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const {getFileLocation} = require("../model"); | ||
|
|
||
| function getExpiration() { | ||
| const expiresInSeconds = config.urlExpiresInSeconds || DEFAULT_EXPIRATION_SECONDS; |
Comment on lines
11
to
15
| "dependencies": { | ||
| "@aws-sdk/client-s3": "^3.67.0", | ||
| "@aws-sdk/s3-request-presigner": "^3.67.0", | ||
| "aws-sdk": "^2.906.0", | ||
| "@aws-sdk/cloudfront-signer": "^3.0.0", | ||
| "bent": "^7.3.12", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.