Include skeleton source in segmentation layer for neuroglancer links#222
Merged
fcollman merged 2 commits intoApr 30, 2026
Merged
Conversation
…if one exists Agent-Logs-Url: https://github.com/CAVEconnectome/MaterializationEngine/sessions/7f3d79e7-649d-42d8-b090-3304aafb321c Co-authored-by: bdpedigo <25714207+bdpedigo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add default skeleton source inclusion in neuroglancer links
Include skeleton source in segmentation layer for neuroglancer links
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neuroglancer links generated for materialized tables were not including the skeleton source in the segmentation layer, even when one was defined in the datastack info.
Changes
make_seg_prop_ng_linkandmake_precomputed_annotation_link: Both functions now check for askeleton_sourcefield in the datastack info and append it to the segmentation layer's source list if present.The
get_datastack_info()call is zero-cost here —client.info.segmentation_source()(called just before) already populatesInfoServiceClient's internalinfo_cache. Also cleaned up the source URL variable name fromseg_layertoseg_sourceto remove the shadowing issue with theSegmentationLayerConfigobject.