Fix a summation in reserve margin - #19
Open
idelder wants to merge 1 commit into
Open
Conversation
Signed-off-by: Davey Elder <iandavidelder@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes an over-counting bug in the reserve margin calculations by removing an unintended extra iteration over M.tech_reserve when summing exchange-technology contributions.
Changes:
- Removes a redundant
for t in M.tech_reservegenerator clause inReserveMarginStatic, preventing duplicated/incorrect capacity summation for exchange techs. - Removes the same redundant generator clause in
ReserveMarginDynamic, ensuring exchange-tech firm capacity contributions are not multiplied by the size oftech_reserve.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should definitely not be summing over that. The prior line already gets all techs in the reserve set so this line just O(n2) product sums them all again.