Fix reserve and ramping constraints - #18
Merged
Merged
Conversation
Signed-off-by: Davey Elder <iandavidelder@gmail.com>
Signed-off-by: Davey Elder <iandavidelder@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR brings CANOE’s constraint logic back in sync with fixes previously made in v4, addressing unit/normalization issues in ramping constraints and correcting how exchange technologies contribute to dynamic reserve margins.
Changes:
- Adjust ramping constraints to convert capacity-based limits onto an hourly basis (scaling by
24 * DaysPerPeriod). - Fix seasonal ramping constraints to compute “next” slice hourly activity using the next slice’s hours adjustment.
- Update
ReserveMarginDynamicexchange handling to add firm import commitments and subtract firm export commitments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
2491
to
2494
| * value(M.SegFrac[p, s, d]) | ||
| for (t, v) in M.processReservePeriods[r1r2, p] | ||
| for t in M.tech_reserve | ||
| ) |
Comment on lines
+2496
to
+2500
| # Only consider exchange technologies connecting to this region | ||
| if r2 == r: | ||
| # Add the firm capacity commitment TO this region | ||
| # (this region was guaranteed an import of power) | ||
| available += output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes that were made in v4 but I forgot to apply in CANOE as well (please let this branching die already)