fix command-line argument parsing of integers #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Drive by review:
Sounds like a good idea to me. |
Byron
approved these changes
Mar 19, 2025
|
PS: If you think you can take on the CLI build failure, that would be extra-awesome! It's a known failure, but it's from times where this wasn't tested so changes could silently break the CLI. Maybe it's just a small thing, and the momentum from this PR could be used to solve maybe solve it more easily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires serde_json >= 1.0.130 (latest: 1.0.140)
It seems that version of serde_json pinned loosely to "1":
Thus, a rebuild should work.
Should I also upgrade to
serde_json = "1.0.130"?Closes #542