이미지 로직 & 축제 운영시간 & 명소 위경도 관련 수정 #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 날짜 정보 정규식 개선하여 더 많은 날짜정보 가져오도록 수정 - Festival의 status 필드 삭제 - 고정 상태 -> 현재 날짜 기준으로 상태 측정하도록 수정
WalkthroughRefactors festival dates to LocalDate, removes status usage, and centralizes date formatting via FestivalDateUtil. Adds image URL utilities and propagates imgUrl into search and home/place responses. Introduces Tour API pagination and image-fetching for places, adjusts controllers/services accordingly, and adds new DTOs and error status. Minor repository and logging changes. Changes
Sequence Diagram(s)sequenceDiagram
participant Client as Client
participant FestSvc as FestivalQueryService
participant Repo as FestivalRepository
Client->>FestSvc: getFestivalList(status)
FestSvc->>Repo: findAll()
Repo-->>FestSvc: List<Festival>
Note over FestSvc: today = LocalDate.now()
alt status == ALL
FestSvc-->>Client: all festivals
else status == UPCOMING
FestSvc-->>Client: start != null && today < start
else status == IN_PROGRESS
FestSvc-->>Client: start/end != null && start <= today <= end
else status == COMPLETE
FestSvc-->>Client: end != null && today > end
end
sequenceDiagram
participant Client as TourAPIController
participant Cmd as TourCommandService
participant PlaceAPI as TourPlaceUtil
participant Repo as PlaceRepository
Client->>Cmd: getPlace(placeType, pageSize, pageNum)
Cmd->>PlaceAPI: getPlace(placeType, pageSize, pageNum)
PlaceAPI-->>Cmd: PlaceApiResponseWrapper(items)
loop for each item
Cmd->>PlaceAPI: getImages(contentId)
PlaceAPI-->>Cmd: PlaceImageResponseWrapper(imageItems)
Note over Cmd: Build Place\n- round lat/lng\n- collect firstImage + fetched originImgUrls
end
Cmd->>Repo: saveAllPlaces(placeList) (per-item transactions)
Repo-->>Cmd: persisted
Cmd-->>Client: done
sequenceDiagram
participant Client as TourAPIController
participant Cmd as TourCommandService
participant FestAPI as TourFestivalUtil
participant Repo as FestivalRepository
Client->>Cmd: syncFestivalsFromApi(pageSize, pageNum)
Cmd->>FestAPI: getFestivals(pageSize, pageNum)
FestAPI-->>Cmd: List<FestivalItem>
Note over Cmd: Convert to entities\n- parse LocalDate\n- ensure start/end not null\n- swap if start > end
Cmd->>Repo: saveAll(...)
Repo-->>Cmd: persisted
Cmd-->>Client: done
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Free 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (20)
💤 Files with no reviewable changes (1)
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
명소 위경도
축제 정보
이미지
nullIfBlank()메서드 작성img_url추가Summary by CodeRabbit
New Features
Bug Fixes
Refactor