-
Notifications
You must be signed in to change notification settings - Fork 1
refactor: 불필요한 부분 제거 #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. Walkthrough채팅 WebSocket 컨트롤러와 관련 DTO를 삭제했다. 리뷰, 영업시간(OpenTime), 지역(Region) 도메인 및 레포지토리를 제거하고, 이에 따른 서비스/리포지토리/컨버터/DTO 시그니처와 쿼리를 정리했다. 투어 API 일부 엔드포인트에 OpenAPI 숨김 주석을 추가했고, 검색 DTO에 주석을 보강했다. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant C as Client
participant S as PlaceQueryService
participant PR as PlaceRepository
participant Conv as PlaceDetailsConverter
C->>S: getPlaceDetails(placeId, user)
S->>PR: findByIdWithLIkeAndImage(placeId)
PR-->>S: Place(with images, likes)
S->>Conv: toSightDto(place, placeLikes, placeImages, isLike)
Conv-->>S: PlaceDetailsDto.SightDto (no reviews/grade)
S-->>C: PlaceDetailsResponse
note over S,Conv: 리뷰/Restaurant 경로 제거, Sight 경로만 사용
sequenceDiagram
autonumber
participant C as Client
participant S as PlaceCongestionQueryService
participant PR as PlaceRepository
participant RD as PlaceRedisUtil
C->>S: getPlaceDefault(bounds, type)
S->>PR: findPlacesByLocationAndType(...)
PR-->>S: List<Place>
S->>RD: getCongestion(placeId)
RD-->>S: level
S-->>C: List<PlaceDefaultInfoDto>\n(id, name, congestion, coords, address, isOpen, imgList)\n(no grade/reviewAmount)
note over S: 리뷰 수/평점 미계산
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Free 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (22)
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Summary by CodeRabbit
리팩터
문서