Skip to content

Conversation

@ggamnunq
Copy link
Contributor

@ggamnunq ggamnunq commented Sep 2, 2025

Summary by CodeRabbit

  • 리팩터

    • 장소 상세/지도 응답에서 평점·리뷰 수 제거; 좋아요 수와 기본 정보만 제공.
    • 리뷰 기반 기능 제거 및 식당 전용 상세 보기 통합(관광지 형식으로 제공).
    • 카페 관련 운영시간/휴무일/문의처 표기 제거.
    • 지역/영업시간 관련 내부 모델 제거로 일부 필드 노출/정렬이 달라질 수 있음.
    • 채팅 WebSocket 잔여 코드 제거(기능 변화 없음).
  • 문서

    • 데이터 적재용 일부 API를 문서에서 비공개 처리.

@ggamnunq ggamnunq self-assigned this Sep 2, 2025
@coderabbitai
Copy link

coderabbitai bot commented Sep 2, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

채팅 WebSocket 컨트롤러와 관련 DTO를 삭제했다. 리뷰, 영업시간(OpenTime), 지역(Region) 도메인 및 레포지토리를 제거하고, 이에 따른 서비스/리포지토리/컨버터/DTO 시그니처와 쿼리를 정리했다. 투어 API 일부 엔드포인트에 OpenAPI 숨김 주석을 추가했고, 검색 DTO에 주석을 보강했다.

Changes

Cohort / File(s) Summary of changes
Chat WebSocket 제거
src/main/kotlin/busanVibe/busan/domain/chat/controller/ChatWebSocketController.kt, src/main/kotlin/busanVibe/busan/domain/chat/dto/websocket/UserInfoResponse.kt, src/main/kotlin/busanVibe/busan/domain/chat/dto/websocket/WebSocketErrorDTO.kt
WebSocket 컨트롤러 및 웹소켓 관련 DTO 삭제.
리뷰 도메인/레포 삭제 및 연계 제거
src/main/kotlin/busanVibe/busan/domain/review/domain/Review.kt, src/main/kotlin/busanVibe/busan/domain/review/domain/repository/ReviewRepository.kt, src/main/kotlin/busanVibe/busan/domain/place/service/PlaceQueryService.kt, src/main/kotlin/busanVibe/busan/domain/place/service/PlaceCongestionQueryService.kt, src/main/kotlin/busanVibe/busan/domain/place/dto/PlaceResponseDTO.kt, src/main/kotlin/busanVibe/busan/domain/place/dto/PlaceMapResponseDTO.kt
Review 엔티티/레포 제거. 서비스에서 Review 의존성/로직 및 평점·리뷰수 계산 제거. DTO에서 grade/reviewAmount 필드 삭제 및 시그니처 정리.
영업시간/지역 도메인 및 레포 정리
src/main/kotlin/busanVibe/busan/domain/place/domain/OpenTime.kt, src/main/kotlin/busanVibe/busan/domain/place/repository/OpenTimeRepository.kt, src/main/kotlin/busanVibe/busan/domain/place/domain/Region.kt, src/main/kotlin/busanVibe/busan/domain/place/domain/Place.kt, src/main/kotlin/busanVibe/busan/domain/place/repository/PlaceRepository.kt
OpenTime/Region 엔티티 및 레포 삭제. Place에서 region/reviews/openTime 연관관계 제거. JPQL에서 p.openTime fetch join 제거.
컨버터 정리
src/main/kotlin/busanVibe/busan/domain/place/converter/PlaceDetailsConverter.kt, src/main/kotlin/busanVibe/busan/domain/festival/converter/FestivalConverter.kt
PlaceDetailsConverter에서 리뷰 관련 인자/계산 및 Restaurant 변환 제거, Sight 변환 시그니처 축소. FestivalConverter의 메서드 public 표기 제거(가시성 기본화).
투어 API 변경
src/main/kotlin/busanVibe/busan/domain/tourApi/controller/TourAPIController.kt, src/main/kotlin/busanVibe/busan/domain/tourApi/service/TourCommandService.kt
컨트롤러 메서드에 @Operation(hidden = true) 추가. Place 생성 시 reviews/openTime 설정 제거. CAFE 분기 제거(사용시간/휴무/안내센터 매핑).
보조 타입 삭제/주석
src/main/kotlin/busanVibe/busan/domain/place/enums/Day.kt, src/main/kotlin/busanVibe/busan/domain/place/enums/RegionType.kt, src/main/kotlin/busanVibe/busan/domain/search/dto/SearchResultDTO.kt, src/main/kotlin/busanVibe/busan/domain/user/data/dto/UserLikesDTO.kt
불사용 enum Day/RegionType 삭제. SearchResultDTO에 문서 주석 추가. UserLikesDTO 전체 삭제.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant C as Client
  participant S as PlaceQueryService
  participant PR as PlaceRepository
  participant Conv as PlaceDetailsConverter

  C->>S: getPlaceDetails(placeId, user)
  S->>PR: findByIdWithLIkeAndImage(placeId)
  PR-->>S: Place(with images, likes)
  S->>Conv: toSightDto(place, placeLikes, placeImages, isLike)
  Conv-->>S: PlaceDetailsDto.SightDto (no reviews/grade)
  S-->>C: PlaceDetailsResponse
  note over S,Conv: 리뷰/Restaurant 경로 제거, Sight 경로만 사용
Loading
sequenceDiagram
  autonumber
  participant C as Client
  participant S as PlaceCongestionQueryService
  participant PR as PlaceRepository
  participant RD as PlaceRedisUtil

  C->>S: getPlaceDefault(bounds, type)
  S->>PR: findPlacesByLocationAndType(...)
  PR-->>S: List<Place>
  S->>RD: getCongestion(placeId)
  RD-->>S: level
  S-->>C: List<PlaceDefaultInfoDto>\n(id, name, congestion, coords, address, isOpen, imgList)\n(no grade/reviewAmount)
  note over S: 리뷰 수/평점 미계산
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

귀 쫑긋 토끼가 깡총깡총 뛰며 말해요:
리뷰와 시간표는 가볍게 내려놨어요, 훨씬 산뜻하죠!
지도를 펴고 좋아요만 세어 보며 달려가요.
웹소켓은 굿바이, 문서는 살짝 숨김표.
새 길이 트였네—봄풀 같은 코드여, 가볍게 자라라! 🥕🌿


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Free

💡 Knowledge Base configuration:

  • Jira integration is disabled
  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4996a2a and 3912674.

📒 Files selected for processing (22)
  • src/main/kotlin/busanVibe/busan/domain/chat/controller/ChatWebSocketController.kt (0 hunks)
  • src/main/kotlin/busanVibe/busan/domain/chat/dto/websocket/UserInfoResponse.kt (0 hunks)
  • src/main/kotlin/busanVibe/busan/domain/chat/dto/websocket/WebSocketErrorDTO.kt (0 hunks)
  • src/main/kotlin/busanVibe/busan/domain/festival/converter/FestivalConverter.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/place/converter/PlaceDetailsConverter.kt (0 hunks)
  • src/main/kotlin/busanVibe/busan/domain/place/domain/OpenTime.kt (0 hunks)
  • src/main/kotlin/busanVibe/busan/domain/place/domain/Place.kt (0 hunks)
  • src/main/kotlin/busanVibe/busan/domain/place/domain/Region.kt (0 hunks)
  • src/main/kotlin/busanVibe/busan/domain/place/dto/PlaceMapResponseDTO.kt (0 hunks)
  • src/main/kotlin/busanVibe/busan/domain/place/dto/PlaceResponseDTO.kt (0 hunks)
  • src/main/kotlin/busanVibe/busan/domain/place/enums/Day.kt (0 hunks)
  • src/main/kotlin/busanVibe/busan/domain/place/enums/RegionType.kt (0 hunks)
  • src/main/kotlin/busanVibe/busan/domain/place/repository/OpenTimeRepository.kt (0 hunks)
  • src/main/kotlin/busanVibe/busan/domain/place/repository/PlaceRepository.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/place/service/PlaceCongestionQueryService.kt (0 hunks)
  • src/main/kotlin/busanVibe/busan/domain/place/service/PlaceQueryService.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/review/domain/Review.kt (0 hunks)
  • src/main/kotlin/busanVibe/busan/domain/review/domain/repository/ReviewRepository.kt (0 hunks)
  • src/main/kotlin/busanVibe/busan/domain/search/dto/SearchResultDTO.kt (1 hunks)
  • src/main/kotlin/busanVibe/busan/domain/tourApi/controller/TourAPIController.kt (2 hunks)
  • src/main/kotlin/busanVibe/busan/domain/tourApi/service/TourCommandService.kt (0 hunks)
  • src/main/kotlin/busanVibe/busan/domain/user/data/dto/UserLikesDTO.kt (0 hunks)

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Join our Discord community for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ggamnunq ggamnunq merged commit 5633140 into main Sep 2, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants