Implement write_uXX_from #166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurntSushi
requested changes
Jan 6, 2021
| /// | ||
| /// let mut wtr = Vec::new(); | ||
| /// wtr.write_u32_from::<BigEndian>(&src).unwrap(); | ||
| /// assert_eq!(&wtr, &[255, 0, 0, 0, 4, 255, 0, 0]); |
There was a problem hiding this comment.
These bytes are little endian. Not big endian.
Which makes sense, because the implementation never takes byte order into account. T is unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discussed in #155, and makes my life much easier when serializing big vectors.
For now I only implemented
write_u32_from, but if this looks OK I can go implement all the others too. I also createdslice_to_u8based onslice_to_u8_mut, but I don't think the comment about "modification of the binary representation of anyCopytype" applies to it.