Skip to content

test: stabilize Design tutorial interaction coverage - #5621

Merged
steve8708 merged 3 commits into
mainfrom
steve8708/changes-12100
Sep 22, 2026
Merged

steve8708 merged 3 commits into
mainfrom
steve8708/changes-12100

Conversation

@steve8708

Copy link
Copy Markdown
Contributor

Summary

  • prefer authored layer roots over generated text spans in tutorial selection helpers so physical clicks land in selectable content
  • model the in-place Interact preview correctly: editor rails and screen shells remain mounted, with a usable preview iframe
  • cover the full 15-step Tutorial 5 flow without stale chrome assumptions

Validation

  • E2E_PORT=9464 E2E_RUN_ID=tutorial5-step9-fix2-20260922 corepack pnpm exec playwright test e2e/parity-tutorial-5.spec.ts --config=playwright.config.ts --project=chromium --workers=1 --reporter=line -g 'step 9:' (1 passed)
  • E2E_PORT=9463 E2E_RUN_ID=tutorial5-helper-fix2-20260922 corepack pnpm exec playwright test e2e/parity-tutorial-5.spec.ts --config=playwright.config.ts --project=chromium --workers=1 --reporter=line (15 passed)
  • git diff --check

@github-actions

github-actions Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Here's a visual recap of what changed:

Visual recap

Open the full interactive recap

@github-actions
github-actions Bot temporarily deployed to pr-5621-design September 22, 2026 14:57 Destroyed
builder-io-integration[bot]

This comment was marked as outdated.

@github-actions
github-actions Bot temporarily deployed to pr-5621-design September 22, 2026 15:28 Destroyed

@builder-io-integration builder-io-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builder reviewed your changes — looks good ✅

Review Details

Code Review Summary

This incremental update addresses the prior false-positive concern by adding data-screen-interact-mode, derived from the actual per-screen interactMode state, and making enterInteractView assert a scoped false → true transition on the shell containing the clicked Interact control. The iframe size poll is also scoped to that same shell. The authored-layer selection priority remains appropriately limited to exact text matches, and the existing Tutorial 5 assertions now sit behind a meaningful transition check.

No confirmed bugs or regressions were found by either independent review agent. The change is low risk: the application addition is a test-observability attribute and the remaining changes are E2E helper/spec updates.

🧪 Browser testing: Skipped — browser automation was unavailable in the verification session. The dev server was healthy, but all planner executors lacked Chrome tooling; 14 grounded test cases were prepared and could not execute.

@steve8708
steve8708 merged commit 9f4657f into main Sep 22, 2026
48 checks passed
@steve8708
steve8708 deleted the steve8708/changes-12100 branch September 22, 2026 15:46

This branch was successfully deployed

No deployments
pr-5621-design 76941d12 Deployed Sep 22, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant