Fix live resize gestures at overview zoom - #5620
Conversation
|
Here's a visual recap of what changed: Open the full interactive recap |
There was a problem hiding this comment.
Builder reviewed your changes — looks good ✅
Review Details
Code Review Summary
PR #5620 adds primary-pointer capture on the selection overlay before the existing mouse-driven resize/move lifecycle, and keeps the generated bridge in sync. The focused regression models a transformed, clipped iframe and drags a resize handle beyond the visible preview, validating that both dimensions continue to update. The guard for read-only mode and non-primary buttons preserves existing behavior, and browser pointer capture should release automatically at gesture completion. The source/generated parity and test shape were independently reviewed by two agents with no clear user-impacting issues found.
Risk assessment: Low. This is a localized UI interaction fix with no auth, data, API, or persistence changes.
✅ Good coverage includes the real scaled-iframe scenario rather than only asserting source text, and the changelog entry is present.
🧪 Browser testing: Could not verify — the dev server is healthy, but all browser-test executor attempts lacked callable Chrome automation tools; the focused and related flows need rerunning when that environment is available.

Live localhost screens render inside transformed iframes at overview zoom. Resize and rotation handles receive the initial pointerdown, but without pointer capture the first move leaves the iframe and the existing document listeners never receive the rest of the gesture.
This fix captures the pointer on the selection overlay before the existing resize/move handler starts. It includes a real Playwright regression using a transformed overview-scale iframe, regenerated bridge output, and a changelog entry.
Validation:
Beta verification will follow the production publisher.