Skip to content

Fix live resize gestures at overview zoom - #5620

Merged
steve8708 merged 2 commits into
mainfrom
steve8708/visual-edit-pointer-capture-20260922
Sep 22, 2026
Merged

steve8708 merged 2 commits into
mainfrom
steve8708/visual-edit-pointer-capture-20260922

Conversation

@steve8708

Copy link
Copy Markdown
Contributor

Live localhost screens render inside transformed iframes at overview zoom. Resize and rotation handles receive the initial pointerdown, but without pointer capture the first move leaves the iframe and the existing document listeners never receive the rest of the gesture.

This fix captures the pointer on the selection overlay before the existing resize/move handler starts. It includes a real Playwright regression using a transformed overview-scale iframe, regenerated bridge output, and a changelog entry.

Validation:

  • selection-chrome bridge tests: 2 passed
  • bridge guard tests: 173 passed
  • Design bridge typecheck: passed
  • changed-file oxlint: warnings only, no errors
  • diff check: passed

Beta verification will follow the production publisher.

@github-actions

github-actions Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Here's a visual recap of what changed:

Visual recap

Open the full interactive recap

@steve8708
steve8708 merged commit 5512e6c into main Sep 22, 2026
16 of 18 checks passed
@steve8708
steve8708 deleted the steve8708/visual-edit-pointer-capture-20260922 branch September 22, 2026 14:25

@builder-io-integration builder-io-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builder reviewed your changes — looks good ✅

Review Details

Code Review Summary

PR #5620 adds primary-pointer capture on the selection overlay before the existing mouse-driven resize/move lifecycle, and keeps the generated bridge in sync. The focused regression models a transformed, clipped iframe and drags a resize handle beyond the visible preview, validating that both dimensions continue to update. The guard for read-only mode and non-primary buttons preserves existing behavior, and browser pointer capture should release automatically at gesture completion. The source/generated parity and test shape were independently reviewed by two agents with no clear user-impacting issues found.

Risk assessment: Low. This is a localized UI interaction fix with no auth, data, API, or persistence changes.

✅ Good coverage includes the real scaled-iframe scenario rather than only asserting source text, and the changelog entry is present.

🧪 Browser testing: Could not verify — the dev server is healthy, but all browser-test executor attempts lacked callable Chrome automation tools; the focused and related flows need rerunning when that environment is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant