Skip to content

feat(clips): refine Dictate and empty states - #5579

Merged
shawnmcclelland merged 11 commits into
mainfrom
shawnmcclelland/changes-100035
Sep 23, 2026
Merged

shawnmcclelland merged 11 commits into
mainfrom
shawnmcclelland/changes-100035

Conversation

@shawnmcclelland

@shawnmcclelland shawnmcclelland commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Refine Dictate history with single-line previews that expand into full transcripts, without duplicate-text flashes or a moving chevron.
  • Reveal cleanup, copy, info, and delete controls in an aligned expanded toolbar. Keep the cleanup button recognizable with a green success state after processing.
  • Move time and duration into a compact shadcn info popover and remove capture-source badges and transcript tabs.
  • Align Library, Spaces, Meetings, and Dictate empty states with shared shadcn composition, clearer copy, responsive wrapping, and one primary action.
  • Make Meetings navigation respect its Labs toggle, and use the dedicated Labs server entry point.
  • Add localized info-popover labels in all 11 Clips catalogs.

Validation

  • 13 targeted Vitest tests passed for Dictate and Library layout.
  • Modified-file formatting and diff checks passed.
  • Clips typecheck passed; its wrapper still reports existing missing production auth/database configuration in this local environment.
  • Lint completed without errors; the existing library-layout effect-cleanup ref warning remains.
  • Browser verified single-line truncation, full-text expansion, aligned controls, info-popover interaction, Escape focus return, and outside-click dismissal; no browser errors observed.
  • All 11 catalogs contain the new metadata labels. Full localization guards could not run because the local Docs dependency link for remark-mdx is missing.

@github-actions

github-actions Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Here's a visual recap of what changed:

Visual recap

Open the full interactive recap

@github-actions
github-actions Bot temporarily deployed to pr-5579-clips September 22, 2026 00:58 Destroyed
builder-io-integration[bot]

This comment was marked as outdated.

@github-actions
github-actions Bot temporarily deployed to pr-5579-clips September 22, 2026 01:21 Destroyed
builder-io-integration[bot]

This comment was marked as outdated.

builder-io-integration[bot]

This comment was marked as outdated.

@github-actions
github-actions Bot temporarily deployed to pr-5579-clips September 22, 2026 15:12 Destroyed
builder-io-integration[bot]

This comment was marked as outdated.

@github-actions
github-actions Bot temporarily deployed to pr-5579-clips September 22, 2026 16:05 Destroyed

@builder-io-integration builder-io-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builder reviewed your changes and found 2 potential issues 🟡

Review Details

Incremental Code Review Summary

The latest head keeps the prior Dictate, empty-state, and localization fixes, but the previously reported owner-only deletion authorization and Library empty/no-results search regressions remain unresolved and are still visible in existing review threads; they are not duplicated here.

Two new Dictate regressions were identified:

  • 🟡 MEDIUM — Vocabulary management is hidden until a dictation exists or capture is active, preventing first-time users from configuring recognition terms before their first capture.
  • 🟡 MEDIUM — After cleanup creates cleanedText, the expanded card remains on the Original tab because the view effect only handles removal of processed text; the successful cleanup result is not surfaced automatically.

The PR remains high risk because it contains destructive dictation deletion. Focused guards and tests were reported as passing where the repository aliases resolved; some direct test invocations remain environment/alias constrained.

🧪 Browser testing: Will run after this review (PR touches UI code)

Comment thread templates/clips/app/routes/_app.dictate.tsx Outdated
Comment thread templates/clips/app/routes/_app.dictate.tsx Outdated
@github-actions
github-actions Bot temporarily deployed to pr-5579-clips September 22, 2026 16:53 Destroyed
@github-actions
github-actions Bot temporarily deployed to pr-5579-clips September 22, 2026 17:54 Destroyed
@shawnmcclelland
shawnmcclelland enabled auto-merge (squash) September 22, 2026 18:22
@shawnmcclelland
shawnmcclelland merged commit 1d6abab into main Sep 23, 2026
48 checks passed
@shawnmcclelland
shawnmcclelland deleted the shawnmcclelland/changes-100035 branch September 23, 2026 00:08

This branch was successfully deployed

No deployments
pr-5579-clips 81d8096e Deployed Sep 22, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants