Skip to content

prevent empty snippets being saved, don't crash for old empty snippets #15114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2024
Merged

prevent empty snippets being saved, don't crash for old empty snippets #15114

merged 1 commit into from
Dec 3, 2024

Conversation

shogunpurple
Copy link
Member

Description

Fixes some issues with snippets:

  • Prevents saving of empty snippets
  • Prevents the builder crashing from empty snippets saved before this
  • Fixes name validation - it was causing an error when you tried to edit an existing snippet because the name existed

Addresses

Launchcontrol

Fix issues with snippets crashing builder UI

@qa-wolf QA Wolf
Copy link

qa-wolf bot commented Dec 3, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added the size/s label Dec 3, 2024
PClmnt
PClmnt approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@PClmnt PClmnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shogunpurple shogunpurple merged commit 188c403 into master Dec 3, 2024
19 checks passed
@shogunpurple shogunpurple deleted the snippets-fix branch December 3, 2024 19:00
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PClmnt PClmnt PClmnt approved these changes

Assignees
No one assigned
Labels
size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shogunpurple @PClmnt