Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API typing - app service A -> D #15100

Merged
merged 16 commits into from
Dec 3, 2024
Merged

API typing - app service A -> D #15100

merged 16 commits into from
Dec 3, 2024

Conversation

mike12345567
Copy link
Collaborator

Description

This PR contains the typing for A -> D APIs in the app service - this includes automations and applications.

@mike12345567 mike12345567 self-assigned this Dec 2, 2024
@mike12345567 mike12345567 requested a review from a team as a code owner December 2, 2024 14:56
@mike12345567 mike12345567 requested review from adrinr and removed request for a team December 2, 2024 14:56
@qa-wolf QA Wolf
Copy link

qa-wolf bot commented Dec 2, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/m labels Dec 2, 2024
@github-actions github-actions bot added size/l and removed size/m labels Dec 2, 2024
adrinr
adrinr reviewed Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@adrinr adrinr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's so nice seeing this!

packages/types/src/api/web/app/user.ts Show resolved Hide resolved
packages/types/src/api/web/deployment.ts Outdated Show resolved Hide resolved
packages/server/src/api/controllers/auth.ts Outdated Show resolved Hide resolved
adrinr
adrinr approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@adrinr adrinr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mike12345567 mike12345567 merged commit 10cf58e into master Dec 3, 2024
19 checks passed
@mike12345567 mike12345567 deleted the chore/api-typing branch December 3, 2024 11:51
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adrinr adrinr adrinr approved these changes

Assignees

@mike12345567 mike12345567

Labels
firestorm Data/Infra/Revenue Team size/l
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mike12345567 @adrinr