Initial conversion of frontend-core API client to TS #15096
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… only watch src dirs
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
…ormity of flattened function params
…o frontend-core-ts-2
…o frontend-core-ts-2
…o frontend-core-ts-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains the initial conversion of the core API client and some endpoints to TS. Endpoints are still being converted, but this PR will complete all required tooling changes to full support TS in frontend core and dependent packages.
As well as the core API client, this PR converts the following client endpoints to TS:
Along with the TS conversion, certain endpoints have had their arguments flattened and the calling code updated accordingly. Most endpoints have types for the server response, but a certain number do not. These are easily identifiable in any given file as I've split them up into their own section, and they remain typed as
any.My usage of
typevsinterfaceis pretty much arbitrary so I welcome any recommendations or changes to that, as well as the location of types.