Remove all traces of legacy custom layouts #15033
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
aptkingston
added
the
do not merge
aptkingston
commented
Nov 19, 2024
| logoUrl | ||
| ) | ||
|
|
||
| const getLayoutSettings = (screen, embedded, app, navigation, logoUrl) => { |
There was a problem hiding this comment.
This is the only real addition in this PR. Logic for how the layout component is rendered has moved from the screen store into the Router here.
…into remove-custom-layouts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes all legacy code dealing with custom layouts. We removed support for custom layouts in July 2022, so I think the time has definitely come to stop supporting them altogether. Current support (before this PR) was only for migrating away from them, but it's been impossible to edit custom layouts for over 2.5 years. I highly doubt there are apps running that are over 2.5 years old but using the latest version of Budibase.
The reason this cannot curently be merged is that all our templates (aside from the 3 new ones) were created using custom layouts. That means that using one of those old templates will create an app that is missing whatever navigation settings existed in the app, as any migration logic that understood the legacy structure has been removed. So until we do something with the multitude of old app templates, this cannot be merged.
I still feel like this is an important piece of work to do - simplify things and remove tonnes of deprecated code - so is worth keeping the PR around as motivation to think about how we want to handle legacy templates.