Feature/api cordinator#1
Open
BuddiBisong wants to merge 4 commits into
Open
Conversation
…e getCompletedOrderSnapshots repository function, and fix order transitions route
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & Why
One or two paragraph summary of the change and the problem it solves. Link the issue with
Closes #…orRefs #….Touched surface
Tick every layer this PR changes:
frontend/— React + Vite bridge UIpackages/sdk/— shared TypeScript SDKcoordinator/— order book + REST/WS serviceresolver/— community resolver runnerrelayer/— legacy v1 listener / watchdog (changes here need extra scrutiny)contracts/— Solidity v2 (HTLCEscrow,ResolverRegistry)soroban/— Stellar Soroban contracts (oversync-htlc,oversync-resolver-registry)docs/— documentation only.github/workflows/,docker,env.example)Settlement & refund semantics
Critical for SCF / investor review. If any box is checked, the PR must also update
docs/REVIEW_RESPONSE.mdand link the updated section in the PR description.Tests run
Tick the matches your change and paste the outcome below. Commands mirror the matrix in
CONTRIBUTING.md.pnpm --filter @oversync/sdk build && pnpm --filter @oversync/sdk exec tsc --noEmitpnpm --filter @oversync/sdk testpnpm --filter @oversync/coordinator exec tsc --noEmit && pnpm --filter @oversync/coordinator testpnpm --filter @oversync/resolver exec tsc --noEmit && pnpm --filter @oversync/resolver testpnpm --filter @oversync/frontend exec tsc --noEmit && pnpm --filter @oversync/frontend testpnpm --filter @oversync/contracts compile && pnpm --filter @oversync/contracts exec hardhat test test/v2/HTLCEscrow.test.ts test/v2/ResolverRegistry.test.tscd soroban && stellar contract build && cargo test --release(cd contracts && forge test --match-path "test/foundry/*" -v)(Solidity fuzz / invariant)pnpm test:e2e(cross-chain differential harness)node scripts/verify-addresses.mjs— required if addresses, configs, orenv.examplechangenode scripts/check-evidence-links.mjs— advisory; required if docs links changeFree-form outcome:
UI / evidence artefacts
Required if the PR changes the frontend, observability, dashboards, or any docs that claim status, metrics, or addresses. Otherwise write
n/a.curlsnippet + JSON response sample pasted belowdocs/examples/metrics-snapshot.example.json(or new JSON in PR)Secrets, logging, and PII risk
.envcontent, wallet mnemonics, or preimages added to the repoconsole.*/logger.*line that prints secrets, preimages, signed payloads, or PIIVITE_*andesbuild.droppolicy still holds)Public proof links (SCF / investor evidence)
Only required for SCF tranche PRs or investor evidence packs. Otherwise write
n/a./metrics,/health, public Grafana):https://github.com/karagozemin/OverSync/actions/runs/…):Breaking change & rollback
Reviewer checklist (for the PR author to self-verify)
git revertrestores prior state