ci: guard the branches this repo actually has - #8
Open
BryanZaneee wants to merge 1 commit into
Open
Conversation
`main` has never existed here — the trunk is `master` — so half the push trigger was dead the day it was written. `develop` is the branch that now receives every merge, and it was not guarded at all. Closes #5 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
branches: [main, master]→[master, develop]in the push trigger.Why
mainhas never existed in this repo, so half that trigger was dead the day it was written.developnow receives every merge and was not guarded at all. Closes #5.Changes
One line in
.github/workflows/test.yml.pull_request:is unqualified and already covers PRs to any branch, so it needs no change.Testing
The workflow running on this PR is the test. Node matrix stays 20/22/24 — it collapses to 24 in T0, where
enginesmoves and the change is justified by type stripping rather than done speculatively here.Checklist
test/generic.test.mjsgreenADR