Repository navigation
patch.py --help lists the device's options; drop --clock-tileset-index - #123
Merged
Merged
Conversation
The first parse_known_args() saw -h and exited before any device added its options, so --help showed only the shared ones (the amalgam's own help branch was unreachable). -h is now added after that parse, and with --help the device's options (both models' for the amalgam) are added before printing. Device.add_arguments is a classmethod, so help needs no stock backups. make help passes PATCH_PARAMS through. --clock-tileset-index was accepted but never read. Output unchanged (golden hashes match). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
patch.py --helpprinted only the shared options for every device (the amalgam too): the firstparse_known_args()saw-hand exited before the device added its options, which also made the amalgam's own help branch inamalgam.configureunreachable.-his added after the first parse; with--help, the device's options (both models' for--device=amalgam, withconflict_handler="resolve") are added before printing.Device.add_argumentsis a classmethod (no implementation used the instance), so--helpworks without the stock backups.make helppassesPATCH_PARAMSthrough:make PATCH_PARAMS="--device=zelda" help.--clock-tileset-indexis removed (accepted but never read), along with its README row.Testing: all 464 tests pass and the golden hashes are unchanged (output is byte-identical); checked
--helpfor mario, zelda and amalgam, and from a directory without backups. No hardware check needed.🤖 Generated with Claude Code