Feat: Add event classes for brewing

[Thorinwasher]

One for each structure type

[Thorinwasher]

(assigning all the team as reviewers, as it's in dupe sensitive territory)

[Jsinco]

The ItemTransaction data class kind of scares me. I understand that it has to be exposed to the API but I'd consider marking the next release as experimental at least for a little while

[Jsinco]

Maybe don't use lombok here and document what denied is? Not super apparent at a glance, but that could just be me

[Jsinco]

I feel like denied and cancelled have too similar of a meaning in these events. Maybe just use cancelled instead of both? Or possibly take a page out of Bukkit's book and use an enumerator to more explicitly declare what is happening

[Thorinwasher]

Look again, I changed how it works now.

[Tisawesomeness]

The event.getCurrentItem() and other items referenced by the event are mapped to real items in memory (either items or slots, Spigot docs aren't clear on this), so Spigot could modify the item before the next tick. Is this properly accounted for in the scheduled task? If not, we may need to clone ItemStacks before passing them to ItemSource.

[Thorinwasher]

That seems to be true, as when I cloned it, the issue with items not converting format got fixed. I think not cloning it is just going to cause undefined behavior, which is why it probably worked when I tested it.

[Tisawesomeness]

A small bug: Taking a brew with expanded lore out of a barrel does not reset the lore to how it should appear in-inventory.

[Thorinwasher]

A small bug: Taking a brew with expanded lore out of a barrel does not reset the lore to how it should appear in-inventory.

I only tested with a distillery, which is where it looks like it worked, it should be the same with barrels. How did you take out the brew?

[Tisawesomeness]

I only tested with a distillery, which is where it looks like it worked, it should be the same with barrels. How did you take out the brew?

Shift-clicking and left-click pickup both cause the issue. You have to leave the brew in a barrel long enough for it to update and get expanded lore.

[Thorinwasher]

I forgot to include hopper based inventory transactions as well. Those need to be tracked too 😃

[Thorinwasher]

And inventory drag event? It will probably take a while until I would be able to complete this myself, any help is appreciated.

[Tisawesomeness]

Seems like most of the issues have been worked out now. The events need a way to modify the item/brew being inserted or extracted (possibly a simple setBrew(Brew) for brew-based events, and setItem(ItemStack) for item-based events), so addons can add meta and ingredients when necessary.

[Thorinwasher]

Seems like most of the issues have been worked out now. The events need a way to modify the item/brew being inserted or extracted (possibly a simple setBrew(Brew) for brew-based events, and setItem(ItemStack) for item-based events), so addons can add meta and ingredients when necessary.

See ItemTransactionSession, or whatever that is called.