Skip to content

refactor(app): rename cached context accessors#1

Closed
Brendonovich wants to merge 1 commit into
share-session-syncfrom
ensure-contexts
Closed

refactor(app): rename cached context accessors#1
Brendonovich wants to merge 1 commit into
share-session-syncfrom
ensure-contexts

Conversation

@Brendonovich

Copy link
Copy Markdown
Owner

Summary

  • rename cached server context access from createServerCtx to ensureServerCtx
  • rename directory SDK and sync accessors to ensureDirSdkContext and ensureDirSyncContext
  • retain create* naming for the private functions that always instantiate contexts

Stack

Testing

  • bun typecheck in packages/app
  • bun test --only-failures --preload ./happydom.ts ./src/context/server-sync.test.ts ./src/context/layout.test.ts ./src/context/layout-scroll.test.ts ./src/utils/refcount.test.ts
  • repository-wide bun turbo typecheck push hook
  • production first-navigation benchmark rerun was blocked because its configured port 3000 was already occupied; the parent baseline previously failed before collecting metrics because the smoke fixture did not render its expected session title

@Brendonovich

Copy link
Copy Markdown
Owner Author

Superseded by upstream PR anomalyco#33627 after the parent PR merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant