Skip to content

Feature/bi 2389#169

Open
cvacalares wants to merge 5 commits intodevelopfrom
feature/BI-2389
Open

Feature/bi 2389#169
cvacalares wants to merge 5 commits intodevelopfrom
feature/BI-2389

Conversation

@cvacalares
Copy link
Collaborator

Description

BI-2389 - Verify correct entry numbers on all germplasm export list
Add support for download files.
Add support for comparing values inside an xls file.

Testing

https://github.com/Breeding-Insight/taf/actions/runs/15965305245

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation

Add step definition to compare values of a cell in excel file.
Add support for downloading files.
@cvacalares cvacalares requested review from a team, davedrp and mlm483 and removed request for a team June 30, 2025 19:18
Copy link
Contributor

@mlm483 mlm483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks alright, there are some confusing comments I would clean up.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is used in several features, I might change the comment to make it clear that it's not just example code.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this.browser.page.page().click('#germplasm-download-file'); // Replace with your actual selector
this.browser.page.page().click('#germplasm-download-file');

Copy link
Contributor

@davedrp davedrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test fails to complete. ( see my custom run or the latest daily run ) I think there is a problem with the chrome driver. I get the following error:
Error
Response 500 POST /session (13039ms)
{
value: {
error: 'session not created',
message: 'session not created: This version of ChromeDriver only supports Chrome version 136\n' +
'Current browser version is 138.0.7204.49 with binary path /opt/google/chrome/chrome',
stacktrace: ''
}
}

# Conflicts:
#	cucumber.conf.js
#	package.json
@cvacalares
Copy link
Collaborator Author

@davedrp - Done

@cvacalares cvacalares requested a review from davedrp September 3, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments