Skip to content

Feature/bi 2391#168

Open
cvacalares wants to merge 11 commits intodevelopfrom
feature/BI-2391
Open

Feature/bi 2391#168
cvacalares wants to merge 11 commits intodevelopfrom
feature/BI-2391

Conversation

@cvacalares
Copy link
Collaborator

@cvacalares cvacalares commented Jun 29, 2025

Description

BI-2391 - Experimental Collaborator with non System Admin roles cannot see a delete button next to each collaborator

Testing

Please include a link to a successful run of TAF for this change

Checklist:

  • [x ] I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation

@cvacalares cvacalares requested review from a team, dmeidlin and mlm483 and removed request for a team June 29, 2025 18:58
Comment on lines 48 to 49
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
And user can see "test user(test@mailinator.com)" as Collaborator
And user can not see "test user(test@mailinator.com)" delete button of Collaborator
Then user can see "test user(test@mailinator.com)" as Collaborator
And user can not see "test user(test@mailinator.com)" delete button of Collaborator

I think this would be more idiomatic gherkin.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@cvacalares
Copy link
Collaborator Author

@mlm483 - Done

# Conflicts:
#	cucumber.conf.js
@cvacalares cvacalares requested a review from mlm483 September 3, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments