Open
Conversation
Add function isDeleteVisible for checking the delete button of the collaborator.
cvacalares
requested review from
a team,
dmeidlin and
mlm483
and removed request for
a team
dmeidlin
approved these changes
Jun 30, 2025
mlm483
requested changes
Jul 1, 2025
src/features/BI-2390.feature
Outdated
Comment on lines
54
to
57
| And user can see "Experimental Collaborator1(experimentcollaborator1@mailinator.com)" as Collaborator | ||
| And user can see "Experimental Collaborator2(experimentcollaborator2@mailinator.com)" as Collaborator | ||
| And user can see "Experimental Collaborator1(experimentcollaborator1@mailinator.com)" delete button of Collaborator | ||
| And user can see "Experimental Collaborator2(experimentcollaborator2@mailinator.com)" delete button of Collaborator No newline at end of file |
Contributor
There was a problem hiding this comment.
Suggested change
| And user can see "Experimental Collaborator1(experimentcollaborator1@mailinator.com)" as Collaborator | |
| And user can see "Experimental Collaborator2(experimentcollaborator2@mailinator.com)" as Collaborator | |
| And user can see "Experimental Collaborator1(experimentcollaborator1@mailinator.com)" delete button of Collaborator | |
| And user can see "Experimental Collaborator2(experimentcollaborator2@mailinator.com)" delete button of Collaborator | |
| Then user can see "Experimental Collaborator1(experimentcollaborator1@mailinator.com)" as Collaborator | |
| And user can see "Experimental Collaborator2(experimentcollaborator2@mailinator.com)" as Collaborator | |
| And user can see "Experimental Collaborator1(experimentcollaborator1@mailinator.com)" delete button of Collaborator | |
| And user can see "Experimental Collaborator2(experimentcollaborator2@mailinator.com)" delete button of Collaborator |
I think this is more idiomatic gherkin.
Collaborator
Author
|
@mlm483 - Done. |
mlm483
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BI-2390 - Program Administrator can see a delete button next to each collaborator
Add step definitions for checking Collaborator's delete button.
Testing
Please include a link to a successful run of TAF for this change
Checklist: