Skip to content

Feature/bi 2394#163

Merged
cvacalares merged 5 commits intodevelopfrom
feature/BI-2394
Jun 24, 2025
Merged

Feature/bi 2394#163
cvacalares merged 5 commits intodevelopfrom
feature/BI-2394

Conversation

@cvacalares
Copy link
Collaborator

Description

Add test for BI-2394.
Add step for deleting collaborator.
Add step for checking collaborator.
Update button click to support different types of button selector.

Testing

https://github.com/Breeding-Insight/taf/actions/runs/15129700346

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation

Add new step definitions for checking the collaborator field.
Add step to deleteCollaborator.
Add cliecExecute using expath.
Create function for clickExecute.
@cvacalares cvacalares requested review from a team, HMS17 and mlm483 and removed request for a team May 21, 2025 05:59
Copy link
Contributor

@HMS17 HMS17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. One concern is looking at the github action results. compared to the latest run, it looks like

Feature: Breeding Methods: Scenario: Breeding Methods Management, Step:
Then user can see "Breeding method is in use. Deletion disabled." message < 1ms is getting ambiguous in the run for this card whereas it was passing in the latest run.

Given a new program is created

@BI-2394
@debug
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the debug tag still be here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed it.

@cvacalares
Copy link
Collaborator Author

Overall looks good. One concern is looking at the github action results. compared to the latest run, it looks like

Feature: Breeding Methods: Scenario: Breeding Methods Management, Step: Then user can see "Breeding method is in use. Deletion disabled." message < 1ms is getting ambiguous in the run for this card whereas it was passing in the latest run.

I have fixed this and the latest test result is at https://github.com/Breeding-Insight/taf/actions/runs/15751637480.

@HMS17 HMS17 self-requested a review June 23, 2025 18:27
@cvacalares cvacalares merged commit e6d1af7 into develop Jun 24, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants