BI-2539 - Add GitHub as Alternative OAuth Provider#429
Merged
Conversation
7 tasks
7 tasks
nickpalladino
requested changes
Jun 30, 2025
| process.env.VUE_APP_LOG_LEVEL = process.env.VUE_APP_LOG_LEVEL || 'error'; | ||
| process.env.VUE_APP_BI_REFERENCE_SOURCE = process.env.VUE_APP_BI_REFERENCE_SOURCE || 'breedinginsight.org'; | ||
| process.env.VUE_APP_BRAPI_VENDOR_SUBMISSION_ENABLED = ('true' === process.env.VUE_APP_BRAPI_VENDOR_SUBMISSION_ENABLED); | ||
| process.env.VUE_APP_ALTERNATE_AUTHENTICATION_ENABLED = ('true' === process.env.VUE_APP_ALTERNATE_AUTHENTICATION_ENABLED); |
Member
There was a problem hiding this comment.
I think we should add ALTERNATE_AUTHENTICATION_ENABLED defaulting to false to the environment section of the bi-web service definition in docker-compose.yml in bi-docker-stack.
Contributor
Author
There was a problem hiding this comment.
Done, see Breeding-Insight/bi-docker-stack#58.
mlm483
commented
Jun 30, 2025
nickpalladino
approved these changes
Jun 30, 2025
dmeidlin
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-2539.
These changes add a Sign In with GitHub option for sign in and initial account activation which can be enabled with an environment variable.
bi-api PR (for BI-2539): Breeding-Insight/bi-api#446.Superceded by the bi-api PR for BI-2540: Breeding-Insight/bi-api#473
bi-docker-stack PR: Breeding-Insight/bi-docker-stack#58
Dependencies
bi-api: feature/BI-2539
Testing
The testing of Breeding-Insight/bi-api#473 will largely cover this PR. Additionally, make sure that setting
VUE_APP_ALTERNATE_AUTHENTICATION_ENABLEDtrueandfalsehas the expected effect.Checklist: