Skip to content

BI-2496 When Deleting an Experiment: "Success" message appears even if delete fails. #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davedrp merged 2 commits into from
Feb 17, 2025
Merged

BI-2496 When Deleting an Experiment: "Success" message appears even if delete fails. #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae3df31
WIP
davedrp Feb 4, 2025
bfa1700
[BI-2496] resond to HTTP-Status code
davedrp Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/breeding-insight/dao/ExperimentDAO.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ export class ExperimentDAO {
throw new Error(`Unexpected status code: ${response.status}`);
}
} catch (error) {
console.info("F");
return ResultGenerator.err(error);
}
}
Expand Down
5 changes: 4 additions & 1 deletion src/breeding-insight/service/ExperimentService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,9 @@ export class ExperimentService {
if (!programId) {
return ResultGenerator.err(new Error('Missing or invalid program id'));
}
return await ExperimentDAO.deleteExperiment(programId, experimentId, hasObsUnits);
let response: Result<Error, boolean>;
response = await ExperimentDAO.deleteExperiment(programId, experimentId, hasObsUnits);
if(response.isErr()) throw response.value;
return response;
}
}