BI-2380 - Add Delete Option to Samples View#425
Merged
nickpalladino merged 11 commits intodevelopfrom Feb 13, 2025
Merged
Conversation
mlm483
approved these changes
Feb 12, 2025
| </ExpandableTable> | ||
| </div> | ||
| </div> | ||
| <!-- The following seems to be some old dead code so commented out for now, was causing console errors --> |
Contributor
There was a problem hiding this comment.
I would remove it. If it turns out it was important, we have git history.
Member
Author
There was a problem hiding this comment.
Removed, pushed changes.
davedrp
requested changes
Feb 13, 2025
Contributor
davedrp
left a comment
davedrp
left a comment
There was a problem hiding this comment.
Testing Note:
The front end displayed a success banner when bi-api returned a 500-error (ie. even though nothing was deleted).
Member
Author
Fixed, pushed changes. |
davedrp
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-2380
Dependencies
Testing
Checklist: