BI-2377 - Add Delete Option to Experiments View#423
Conversation
davedrp
requested review from
a team,
dmeidlin and
nickpalladino
and removed request for
a team
| <template> | ||
| <section | ||
| v-bind:id="'deleteModal-' + uniqueId" | ||
| v-bind:class="modalClass" | ||
| > | ||
| <FormModal | ||
| v-bind:active.sync="active" | ||
| v-bind:title="modalTitle" | ||
| v-on:deactivate="closeDeleteModal" | ||
| > | ||
| <template #form> | ||
| <slot name="form" /> | ||
| </template> | ||
| <template #buttons> | ||
| <div class="columns"> | ||
| <div class="column is-whole has-text-centered buttons"> | ||
| <button | ||
| class="button is-primary has-text-weight-bold" | ||
| v-on:click="invokeDeleteAction" | ||
| > | ||
| <strong>Yes</strong> | ||
| </button> | ||
| <button | ||
| class="button" | ||
| v-on:click="closeDeleteModal" | ||
| > | ||
| Cancel | ||
| </button> | ||
| </div> | ||
| </div> | ||
| </template> | ||
| </FormModal> | ||
| </section> | ||
| </template> |
There was a problem hiding this comment.
This modal seems to be based off of /src/components/modals/ConfirmationModal.vue. The germplasm list delete uses ConfirmationModal.vue in the same way DeleteModal is being used here. Is there a reason to add a new modal component or can ConfirmationModal.vue be used for experiments as well?
src/config/AppAbility.ts
Outdated
| import {Ability, AbilityClass} from '@casl/ability'; | ||
|
|
||
| type Actions = 'manage' | 'create' | 'read' | 'update' | 'delete' | 'archive' | 'access' | 'submit'; | ||
| type Actions = 'manage' | 'delete' |'create' | 'read' | 'update' | 'delete' | 'archive' | 'access' | 'submit'; |
There was a problem hiding this comment.
'delete' is already present between update and archive and shouldn't need to be added again.
There was a problem hiding this comment.
Thank you.
Implemented.
davedrp
force-pushed
the
feature/BI-2377
branch
from
316f1e1 to
8146a9e
Compare
davedrp
changed the title
nickpalladino
left a comment
nickpalladino
left a comment
There was a problem hiding this comment.
I think there should probably be a success notification when an experiment is successfully deleted to be consistent with behavior in other areas of the UI. Other than that testing looked good.
|
@nickpalladino The success notification was aded |
davedrp
force-pushed
the
feature/BI-2377
branch
from
0922fff to
a4fdc69
Compare
3 participants
Description
BI-2377 Add Delete Option to Experiments View
Also fixed one accessibility issue ("Text not included in an ARIA landmark")
Dependencies
bi-api: develop
brapi-Java-TestServer: develop (be sure to pull the latest version. there is a needed bug fix)
Testing
Checklist: